Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[release/7.0] Pass resource items for VS generated authoring" #75535

Merged

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 13, 2022

Reverts #75461 which is breaking the official build, we can pick the change back up with other workload work that can't land until rc1 is public

cc @joeloff

@ghost ghost assigned lewing Sep 13, 2022
@lewing
Copy link
Member Author

lewing commented Sep 13, 2022

@carlossanlop you can merge this immediately without waiting for ci

@carlossanlop carlossanlop merged commit 559d9e7 into release/7.0 Sep 13, 2022
@carlossanlop carlossanlop deleted the revert-75461-backport/pr-75454-to-release/7.0 branch September 13, 2022 14:35
@carlossanlop
Copy link
Member

@lewing just to be clear, what was the build failure message? Was it the one below, or a different one?:

/__w/1/s/.dotnet/sdk/7.0.100-rc.1.22425.9/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/__w/1/s/artifacts/log/Layout.Linux.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/__w/1/s/artifacts/log/Layout.Linux.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/__w/1/s/artifacts/log/Layout.Linux.x64.Release.err /flp:Verbosity=normal;LogFile=/__w/1/s/artifacts/log/Layout.Linux.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=Linux /p:NUMBER_OF_PROCESSORS=4 /p:LibrariesConfiguration=Debug /p:RuntimeVariant=llvmfullaot /t:TestBuild /__w/1/s/src/tests/build.proj
  [01:34:36.85] Restoring all packages...
    Determining projects to restore...
    All projects are up-to-date for restore.
    Determining projects to restore...
    All projects are up-to-date for restore.
    Determining projects to restore...
    All projects are up-to-date for restore.
    Determining projects to restore...
    All projects are up-to-date for restore.
    Determining projects to restore...
    All projects are up-to-date for restore.
/__w/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/__w/1/s/.dotnet/dotnet" restore -r linux-x64 Common/XUnitWrapperLibrary/XUnitWrapperLibrary.csproj  /p:SetTFMForRestore=true /p:TargetOS=Linux /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.

Build FAILED.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants