-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] [wasm][debugger] fixing setting a breakpoint in an invalid IL offset after hotreload #75564
Conversation
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #75561 to release/7.0 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #75561 to release/7.0 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Double signed off by @lewing, so that's how I know we really want this merged 😁. CI is green. Ready. |
Backport of #75561 to release/7.0
/cc @thaystg
Customer Impact
When applying hot reload changes the browser could close because we had a crash on BrowserDebugProxy
Testing
Manually tested
Risk
Low risk, only protecting the return of setting the breakpoint to avoid a throw.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.