Clean up of SPC to match ref assembly public surface for Mono and CoreCLR #75954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/libraries/System.Private.CoreLib/src/Internal/Console.Android.cs
Outdated
Show resolved
Hide resolved
...tem.Private.CoreLib/src/System/Runtime/Serialization/SerializationInfo.SerializationGuard.cs
Show resolved
Hide resolved
marek-safar
force-pushed
the
72594
branch
3 times, most recently
from
9e7d314
to
525ace2
Compare
…eCLR Contributes to dotnet#72594
jkotas
reviewed
Sep 21, 2022
.../System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComActivationContextInternal.cs
Show resolved
Hide resolved
jkotas
reviewed
Sep 21, 2022
src/libraries/System.Private.CoreLib/src/System/Resources/ResourceManager.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsContributes to #72594
|
jkotas
reviewed
Sep 22, 2022
src/libraries/System.Private.CoreLib/src/System/Resources/ResourceSet.cs
Outdated
Show resolved
Hide resolved
|
"Installer Build and Test tests" failures are caused by changes in the PR |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
EventSource tests failing on NativeAOT, example: |
jkotas
reviewed
Sep 24, 2022
| MembersMustExist : Member 'public void System.AppContext.remove_ProcessExit(System.EventHandler)' does not exist in the reference but it does exist in the implementation. | ||
| MembersMustExist : Member 'public void System.AppContext.remove_UnhandledException(System.UnhandledExceptionEventHandler)' does not exist in the reference but it does exist in the implementation. | ||
| MembersMustExist : Member 'public void System.Environment.FailFast(System.String, System.Exception, System.String)' does not exist in the reference but it does exist in the implementation. | ||
| MembersMustExist : Member 'protected void System.WeakReference..ctor()' does not exist in the reference but it does exist in the implementation. | ||
| CannotRemoveAttribute : Attribute 'System.Runtime.CompilerServices.TypeDependencyAttribute' exists on 'System.Collections.Generic.Comparer<T>' in the implementation but not the reference. |
There was a problem hiding this comment.
TypeDependencyAttribute is not used for anything. You can delete the attribute and all places where it is mentioned.
jkotas
reviewed
Sep 24, 2022
| @@ -1,35 +1,8 @@ | |||
| Compat issues with assembly System.Private.CoreLib: | |||
| TypesMustExist : Type 'Internal.Console' does not exist in the reference but it does exist in the implementation. | |||
| TypesMustExist : Type 'Internal.Runtime.InteropServices.ComActivationContextInternal' does not exist in the reference but it does exist in the implementation. | |||
There was a problem hiding this comment.
Can ComActivationContextInternal be internal now that ComActivator is internal?
This looks like a pre-existing failure actually. |
|
All known known test errors according to the build analysis. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #72594