Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Flow internal transport packages during servicing #75979

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #75969 to release/7.0

/cc @ViktorHofer

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

This makes sure that partner repositories have their internal transport
packages available. This needs to be set explicitly as during servicing,
libraries only publish on demand.

This also fixes broken 7.0 servicing builds which require at least one
package to be published.

Manual, partial backport of c5a20f9.
@ghost
Copy link

ghost commented Sep 21, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75969 to release/7.0

/cc @ViktorHofer

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 21, 2022

@danmoseley @ericstj this is a tell-mode only change necessary for servicing .NET 7. This came-up in the ".NET 7 Stable Test Build" exercise. For more details please see the underlying PR that targets main.

@carlossanlop
Copy link
Member

Not needed for RC2?

@ViktorHofer
Copy link
Member

No. This won't be necessary until we service .NET 7 which presumably is 7.0.1.

@carlossanlop
Copy link
Member

carlossanlop commented Sep 23, 2022

There's a CI failure I haven't seen before. Could it be related to this PR?

runtime-staging (Build Browser wasm windows Release LibraryTests)

D:\a\_work\1\s\src\libraries\System.Formats.Cbor\tests\CborDocument\unknown(1,1):
error FS3384: (NETCORE_ENGINEERING_TELEMETRY=Build)
The .NET SDK for this script could not be determined. If the script is in a directory using a 'global.json' then ensure the relevant .NET SDK is installed.
The output from 'D:\a\_work\1\s\.dotnet\dotnet.exe --version' in the directory 'D:\a\_work\1\s\src\libraries\System.Formats.Cbor\tests\CborDocument' was:
'Timeout executing command 'D:\a\_work\1\s\.dotnet\dotnet.exe' '--version'' and the exit code was '1'.

cc @eiriktsarpalis in case you've seen this.

@ViktorHofer ViktorHofer merged commit 97faf12 into release/7.0 Sep 26, 2022
@ViktorHofer ViktorHofer deleted the backport/pr-75969-to-release/7.0 branch September 26, 2022 13:28
@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Sep 26, 2022

@carlossanlop I haven't, but that particular path points to an F# test project.

https://github.com/dotnet/runtime/tree/315bdd4c138491df154e84b98ba7fae72ca8b83b/src/libraries/System.Formats.Cbor/tests/CborDocument

IIRC we've had sdk related issues with that project in the past.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants