SPMI: Add and utilize number of contexts with diffs #76011
Conversation
Previously, if there was any diff in a collection, that collection would be shown in all tables (i.e. Overall, FullOpts, MinOpts). The main reason was that we only had "has diffs" information on a per-collection basis, not for each of the categories. This changes SPMI to communicate back for each category how many contexts had diffs in them, and uses this to hide tables/rows without any diffs, and to show this information under details.
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsPreviously, if there was any diff in a collection, that collection would be shown in all tables (i.e. Overall, FullOpts, MinOpts). The main reason was that we only had "has diffs" information on a per-collection basis, not for each of the categories. This changes SPMI to communicate back for each category how many contexts had diffs in them, and uses this to hide tables/rows without any diffs, and to show this information under details.
|
This reverts commit 527e36e. Just hide it completely.
|
cc @dotnet/jit-contrib PTAL @kunalspathak. This makes the hiding of rows/tables a bit more granular, but keeps the table in the "top level view" when there are actual diffs. I debated whether to display "No MinOpts diffs found." in place of the table, but decided to not show anything in the end. |
|
Do you mind making a change in jit to trigger spmi-diff? |
|
Not sure why it shows TP diffs in MinOpts, that is unexpected. I will investigate. You can see the effect of this PR on the x64 asmdiffs, which no longer show the MinOpts table since there are no MinOpts diffs (the spurious arm64 diffs remain -- we should probably look into this asap). |
|
Hmm, looks like our rolling jit build is broken: [15:02:28] try 1: a2b181158fe21fc3be8ce09467f969228c8424eb
[15:02:28] try 2: db5c43370d41cc8efa6c4908c2a74daeb83462db
[15:02:28] try 3: d01e92cc38a179ffae3f81fdcdc3e82ba0a87ba9
D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py:288: DeprecationWarning: The 'warn' function is deprecated, use 'warning' instead
logging.warn("Warning: the baseline found is not built with the first git hash with JIT code changes; there may be extraneous diffs")
[15:02:28] Warning: the baseline found is not built with the first git hash with JIT code changes; there may be extraneous diffs |
|
Looks like the internal JIT rolling build was not triggered on either of those JIT commits (a2b1811 and db5c433); instead it was triggered on b5b2af0 ~1.5 hours later. The net effect is that we uploaded a rolling JIT for a commit hash that is unrelated to the JIT. |
This reverts commit f4cc126.
|
/azp run runtime-coreclr superpmi-replay |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
superpmi-replay timed out in one of the replay legs and the log is empty -- will retry. |
Previously, if there was any diff in a collection, that collection would be shown in all tables (i.e. Overall, FullOpts, MinOpts). The main reason was that we only had "has diffs" information on a per-collection basis, not for each of the categories. This changes SPMI to communicate back for each category how many contexts had diffs in them, and uses this to hide tables/rows without any diffs, and to show this information under details.