[release/6.0] Remove locks from COM events delegate management. #76035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsBackport of #75863 to release/6.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
AaronRobinsonMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Sep 23, 2022
stephentoub
approved these changes
Sep 23, 2022
rbhanda
added
Servicing-approved
|
Approved. Signed-off. CI green. No OOB package authoring changes needed for this one. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75863 to release/6.0
/cc @AaronRobinsonMSFT, @stephentoub
Customer Impact
This is a customer reported issue - #75863, both internal and external to Microsoft. The issue is triggering a COM Event A when handling a COM Event A. It represents a regression form .NET Framework. It was introduced in .NET Core 3.1, but as more people start to move onto .NET 5+ this will hit more. It is limited to COM Events so narrow in customer base, but those that use it will find it difficult to adopt as there is no workaround.
Testing
Validated this using a customer reproduction example. No new test was added due to the complexity of scenario and the narrowness of impact. The implementation was reduced in complexity substantially and is now more in line with best-practice concurrency related solutions in .NET Core.
Risk
This is a minor risk. Invoke locks were removed and immutability of a collection introduced. The reduction of complexity represented in the functional change makes this lower risk but the scenario is limited to COM Events which are even rarer so supporting a minor risk designation.