Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix isolated storage path on mobile #76254

Merged
merged 11 commits into from
Sep 28, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 27, 2022

Backport of #75541 to release/7.0

/cc @steveisok @mkhamoyan

Customer Impact

The path of a file created by IsolatedStorageFile.GetUserStoreForApplication() changes between different builds on iOS, making accessing any previous files created not possible. Environment.ProcessPath was being used as part of the identity hash that goes into the path and this appears to change version to version under iOS.

The fix was to bring in legacy mono behavior that makes a fixed .isolated-storage folder for each app, without the identity hash.

Testing

Automated tests and validated version bumps with a MAUI app.

Risk

Low

@ghost
Copy link

ghost commented Sep 27, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75541 to release/7.0

/cc @steveisok @mkhamoyan

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.IO

Milestone: -

@ghost
Copy link

ghost commented Sep 27, 2022

Tagging subscribers to 'os-maccatalyst': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75541 to release/7.0

/cc @steveisok @mkhamoyan

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: mkhamoyan
Labels:

area-System.IO, os-ios, os-tvos, os-maccatalyst

Milestone: -

@carlossanlop
Copy link
Member

@mkhamoyan can you please fill out the template, add the servicing-consider label, then send an email to Tactics requesting approval?

@simonrozsival @steveisok can you please provide a code review sign-off?

@steveisok steveisok added the Servicing-consider Issue for next servicing release review label Sep 27, 2022
@steveisok steveisok changed the title [release/7.0] 74642 change isostorage path [release/7.0] Fix isolated storage path on mobile Sep 28, 2022
@steveisok steveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 28, 2022
@steveisok
Copy link
Member

Approved by tactics via email.

@carlossanlop
Copy link
Member

Approved by Tactics. Signed off. CI green. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit d3a8847 into release/7.0 Sep 28, 2022
@carlossanlop carlossanlop deleted the backport/pr-75541-to-release/7.0 branch September 28, 2022 21:32
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO os-ios Apple iOS os-maccatalyst MacCatalyst OS os-tvos Apple tvOS Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants