Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Remove VS nupkg push #76313

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Sep 28, 2022

Signing happens at the end of the build now, even with in-build signing. The staging pipeline pushes the nupkgs. This step is not necessary, and pushes unsigned nupkgs.

Signing happens at the end of the build now, even with in-build signing. The staging pipeline pushes the nupkgs. This step is not necessary, and pushes unsigned nupkgs.
@teo-tsirpanis teo-tsirpanis added this to the 7.0.0 milestone Sep 28, 2022
@mmitche mmitche merged commit 0b0c060 into dotnet:release/7.0 Sep 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2022
@mmitche
Copy link
Member Author

mmitche commented Apr 13, 2023

/backport to main

@mmitche mmitche deleted the remove-nupkg-push branch April 13, 2023 18:19
@github-actions github-actions bot unlocked this conversation Apr 13, 2023
@github-actions
Copy link
Contributor

Started backporting to main: https://github.com/dotnet/runtime/actions/runs/4692535380

@github-actions
Copy link
Contributor

@mmitche backporting to main failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Remove VS nupkg push Signing happens at the end of the build now, even with in-build signing. The staging pipeline pushes the nupkgs. This step is not necessary, and pushes unsigned nupkgs.
Using index info to reconstruct a base tree...
A	eng/pipelines/installer/jobs/base-job.yml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): eng/pipelines/installer/jobs/base-job.yml deleted in HEAD and modified in Remove VS nupkg push Signing happens at the end of the build now, even with in-build signing. The staging pipeline pushes the nupkgs. This step is not necessary, and pushes unsigned nupkgs.. Version Remove VS nupkg push Signing happens at the end of the build now, even with in-build signing. The staging pipeline pushes the nupkgs. This step is not necessary, and pushes unsigned nupkgs. of eng/pipelines/installer/jobs/base-job.yml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove VS nupkg push Signing happens at the end of the build now, even with in-build signing. The staging pipeline pushes the nupkgs. This step is not necessary, and pushes unsigned nupkgs.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@mmitche an error occurred while backporting to main, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants