Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPMI: More information on CI failures #77361

Merged
merged 3 commits into from
Oct 24, 2022
Merged

SPMI: More information on CI failures #77361

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8292f03
SPMI: Collect some more info when no file exists
jakobbotsch Oct 23, 2022
b61658e
Update src/coreclr/scripts/superpmi.py
jakobbotsch Oct 24, 2022
55e1cbe
Enhance logging, mark as failing on asmdiffs failure
jakobbotsch Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/coreclr/scripts/superpmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1711,8 +1711,13 @@ async def create_one_artifact(jit_path: str, location: str, flags) -> str:
logging.debug("%sInvoking: %s", print_prefix, " ".join(command))
proc = await asyncio.create_subprocess_shell(" ".join(command), stderr=asyncio.subprocess.PIPE, env=modified_env)
await proc.communicate()
jakobbotsch marked this conversation as resolved.
Show resolved Hide resolved
with open(item_path, 'r') as file_handle:
generated_txt = file_handle.read()
(stdout, stderr) = await proc.communicate()
if os.path.exists(item_path):
with open(item_path, 'r') as file_handle:
generated_txt = file_handle.read()
else:
raise Exception("No JitStdOutFile was created. Exit code: {}\n\nstdout:\n{}\n\nstderr:\n{}".format(proc.returncode, stdout.decode(), stderr.decode()))

return generated_txt

# Generate diff and base JIT dumps
Expand Down