[release/7.0] [Mono] Disable SIMD intrinsics for Vector128/64 on Arm64 #77443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
vargaz
approved these changes
Oct 25, 2022
This was referenced Oct 25, 2022
|
The WASM CI lanes failed with |
rbhanda
added
Servicing-approved
|
Approved by Tactics. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #77406 to release/7.0
/cc @fanyang-mono
Customer Impact
Without this fix, MAUI apps will experience an exception/crash when running on Android with LLVM manually enabled. This issue was reported by developer on the Maui Android team.
Please note : LLVM is disabled by default for MAUI Android, so less users impacted, but should help developers using that property.
Testing
Tests passed in
dotnet/mainfor existing supported platforms and manually verified that Vector128/64 intrinsics are disabled for non-fullAOT mode of MonoVMRisk
The risk is low because this change is simply making Vector128/64 API's using their software fallback implementations, like how they were used to be in .NET6.