-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce OptLevel() in jit #77465
Closed
Closed
Introduce OptLevel() in jit #77465
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c045cf9
Test
EgorBo d23dfab
Fix source of regressions
EgorBo 648220e
Make it zero-diff
EgorBo 8f9e54d
Clean up
EgorBo 46f1b20
Merge branch 'main' of github.com:dotnet/runtime into jit-optlevel
EgorBo 17cdad1
fix arm64 regression
EgorBo 7105010
zero diff
EgorBo 2a61ce7
Replace MinOpts with OptimizationDisabled
EgorBo f379257
Merge branch 'main' of github.com:dotnet/runtime into jit-optlevel
EgorBo 23cc22d
jit-format
EgorBo c473e12
Merge branch 'main' of github.com:dotnet/runtime into jit-optlevel
EgorBo e13dd69
Fix diffs
EgorBo 932bf13
Merge branch 'main' of github.com:dotnet/runtime into jit-optlevel
EgorBo 0a40fba
fix build
EgorBo 9cb3adf
Merge branch 'main' of github.com:dotnet/runtime into jit-optlevel
EgorBo 8c09fd4
OPT_SizeAndThroughput -> OPT_Quick
EgorBo 54bc2dc
Merge branch 'main' of github.com:dotnet/runtime into jit-optlevel
EgorBo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the double negation is hard to read. Can these (there are a number of instances) be switched to
OptimizationEnabled
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but I didn't want to distract code reviewers with that. I think we'd better do it separately, for now it's easier to review because I simply replaced MinOpts with the same OptimizationDisabled so no need to validate it 🙂