Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deleting any kind of nodes after address mode formation #77872

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Allow deleting any kind of nodes after address mode formation #77872

merged 2 commits into from
Nov 7, 2022

Commits on Nov 6, 2022

  1. Allow deleting any kind of nodes after address mode formation 

    This is a general solution to dotnet#77152, allowing for deleting any
set of nodes that contributed to an address mode, especially those
nodes on the `op1` side of a GT_MUL with a zero `op2`.

Note that for the dotnet#77152 case, this deletes all the `op1` nodes,
but leaves behind a dead temp var that was created as part of
long MUL rationalization.

Fixes dotnet#77152.
    @BruceForstall
    BruceForstall committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    4afac32 View commit details
    Browse the repository at this point in the history

  2. Add DEBUG_DESTROY_NODE

    @BruceForstall
    BruceForstall committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    867fd64 View commit details
    Browse the repository at this point in the history