[release/7.0] [wasm] propagate aborted startup to top most promise #78764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lewing and
pavelsavara
as code owners
lewing
approved these changes
Nov 23, 2022
|
@pavelsavara if this is ready, please send an email to Tactics requesting approval. For the January release, we will only have a window of one day to merge backports (Nov. 29-30), so I'm asking all backport submitters to get their PRs ready for me to just hit merge on that day. |
|
This was approved by email. |
carlossanlop
added
Servicing-approved
|
Branding has been done. Milestone is 7.0.2. Signed-off by area owners. Approved by Tactics. No OOB package authoring changes needed. CI is green. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #78644 to release/7.0
Fixes #77882
/cc @pavelsavara
Customer Impact
User reported lack of error propagation. This will propagate errors during early startup sequence into user code, where they could handle it.
Testing
I have done manual testing on the user reported scenario.
Risk
Low. The affected API is new in Net7 and so the usage in the wild is not too broad yet.
The change only affects scenarios which are already failed.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.