Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Move AT_EXECFN to fallback for /proc/self/exe #79057

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 30, 2022

Backport of #78958 to release/7.0

/cc @janvorli @am11

Customer Impact

When building a self-contained console application targeting .NET 7, the console application doesn't work with shebang in Linux. This causes powershell v7.3.0 to stop working with shebang on Linux.
When building the same console application targeting .NET 6, the produced console application works fine with shebang.

Testing

CI coreclr and libraries tests

Risk

Low, the change just swaps the order of means we use for getting the current executable path, the /proc/self/exe is used first now. And in 6.0, we accidentally were using just the /proc/self/exe for some time, so it was well tested.

@ghost
Copy link

ghost commented Nov 30, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78958 to release/7.0

/cc @janvorli @am11

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost
Copy link

ghost commented Nov 30, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78958 to release/7.0

/cc @janvorli @am11

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries, area-Host

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 7.0.x

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 6, 2022
@jeffschwMSFT jeffschwMSFT modified the milestones: 7.0.x, 7.0.3 Dec 6, 2022
@carlossanlop
Copy link
Member

Approved by Tactics for 7.0.3.
Signed-off by area owners.
CI failure is known and unrelated: #79859
No OOB changes needed.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 6b15556 into release/7.0 Jan 4, 2023
@carlossanlop carlossanlop deleted the backport/pr-78958-to-release/7.0 branch January 4, 2023 20:31
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants