Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting DirectSettingsOverrideConfigurationSetting and ConfigurationSettingCanInfluenceEnvironment test failures in CI #79455

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Dec 9, 2022

Ensure the temp directory used is always empty, so it doesn't pick up appsettings.json files randomly.

Fix #79453

Ensure the temp directory used is always empty, so it doesn't pick up appsettings.json files randomly.

Fix dotnet#79453
@eerhardt eerhardt marked this pull request as ready for review December 9, 2022 15:31
@ghost ghost assigned eerhardt Dec 9, 2022
@ghost
Copy link

ghost commented Dec 9, 2022

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Ensure the temp directory used is always empty, so it doesn't pick up appsettings.json files randomly.

Fix #79453

Author: eerhardt
Assignees: -
Labels:

area-Extensions-Hosting

Milestone: -

@eerhardt eerhardt closed this Jan 3, 2023
@eerhardt eerhardt reopened this Jan 3, 2023
@build-analysis build-analysis bot mentioned this pull request Jan 3, 2023
@eerhardt
Copy link
Member Author

eerhardt commented Jan 3, 2023

Failure is #79874.

@eerhardt eerhardt merged commit 795fcec into dotnet:main Jan 3, 2023
@eerhardt eerhardt deleted the Fix79453 branch January 3, 2023 19:20
halter73 pushed a commit that referenced this pull request Jan 3, 2023
Ensure the temp directory used is always empty, so it doesn't pick up appsettings.json files randomly.

Fix #79453
carlossanlop pushed a commit that referenced this pull request Jan 12, 2023
* Do not override content root with default

* Address PR feedback

* Add more test coverage for custom HostApplicationBuilderSettings

* Make package authoring changes

* Fix failing Hosting tests (#79455)

Ensure the temp directory used is always empty, so it doesn't pick up appsettings.json files randomly.

Fix #79453

* Add reference to System.Diagnostics.DiagnosticSource

Co-authored-by: Stephen Halter <halter73@gmail.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants