Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Fixes InvalidCastException when using other attributes #79854

Closed
wants to merge 1 commit into from

Conversation

allantargino
Copy link
Contributor

Originally fixed #67167 in .NET 7, and now fixes #77525 for .NET 6.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 20, 2022
@ghost
Copy link

ghost commented Dec 20, 2022

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Originally fixed #67167 in .NET 7, and now fixes #77525 for .NET 6.

Author: allantargino
Assignees: -
Labels:

area-Extensions-Logging

Milestone: -

@allantargino allantargino changed the title [release/6.0] Fixes InvalidCastException when using other attributes (#67179) [release/6.0] Fixes InvalidCastException when using other attributes Dec 20, 2022
@allantargino allantargino marked this pull request as ready for review December 20, 2022 17:32
@tarekgh tarekgh added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 22, 2022
@tarekgh
Copy link
Member

tarekgh commented Dec 22, 2022

I pasted the question #77525 (comment) to decide if this is serious enough issue to consider porting it to 6.0.

@tarekgh tarekgh added this to the 6.0.x milestone Dec 22, 2022
@tarekgh
Copy link
Member

tarekgh commented Dec 25, 2022

per the comment #77525 (comment) I am closing this PR and we can consider it later if we see demand on that.

@tarekgh tarekgh closed this Dec 25, 2022
@allantargino allantargino deleted the fix/67179 branch January 7, 2023 23:41
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants