Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Use MonoWasmBuildVariant to select runtime variant #80024

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[build] Use MonoWasmBuildVariant to select runtime variant #80024

merged 1 commit into from
Jan 5, 2023
+37 −38

Commits on Jan 5, 2023

  1. [build] Use MonoWasmBuildVariant to select runtime variant 

    Use `MonoWasmBuildVariant=multithread` and
`MonoWasmBuildVariant=perftrace` consistently to select the runtime
variant.  Previously we also supported setting `WasmEnableThreads` or
`WasmEnablePerfTracing` to configure the runtime variant.  This PR
removes support for that.

Note that this is distinct from what users do: the public
`WasmEnableThreads` (respectively, `WasmEnablePerfTracing`) property
are used in user project to choose the threaded (respectively,
diagnostic tracing) runtime pack in a user project.  That support is
not going way in this PR.

The only tricky bit is that when building and testing the sample
projects, we need to set the public properties, not the wasm build
variant property.

Fixes dotnet#75152
    @lambdageek
    lambdageek committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    ebd2ba7 View commit details
    Browse the repository at this point in the history