Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [mono][loader] Set status on success #80951

Merged
merged 1 commit into from
Feb 8, 2023

Commits on Jan 20, 2023

  1. [loader] Set status on success

    Emebedders that call `mono_assembly_load_from_full` may observe a
    non-NULL return value and an uninitialized MonoImageOpenStatus, which
    may lead to incorrect diagnostics in code like:
    
    ```
    MonoImageOpenStatus status;
    MonoAssembly *assembly = mono_assembly_load_from_full (image, name,
    status, refonly);
    if (!assembly || status != MONO_IMAGE_OK) {
       fprintf(stderr, "Failure due to: %s\n", mono_image_strerror (status));
       abort();
    }
    ```
    Which will print `Failure due to: Internal error`
    
    Addresses dotnet/android#7658
    lambdageek authored and github-actions committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    9cfa7ea View commit details
    Browse the repository at this point in the history