Fix publishing to Arcade when there are no merged tests in the set #81054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis change fixes the bug that @naricc hit in his PR #81012 when trying to limit the test set for the purpose of speeding up lab response in certain experiments. My original implementation of Helix publishing changes related to merged tests was incorrect with respect to the case when there are no merged tests in the test set, a situation I never hit as I was making these changes parallel to the first wave of test merging. I have verified by means of the instrumented run that Nathan's change passes with my fix. Thanks Tomas
|
naricc
approved these changes
Jan 24, 2023
|
The one failure on Linux arm seems to be known issue #80666, merging in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the bug that @naricc hit in his PR #81012 when trying to limit the test set for the purpose of speeding up lab response in certain experiments. My original implementation of Helix publishing changes related to merged tests was incorrect with respect to the case when there are no merged tests in the test set, a situation I never hit as I was making these changes parallel to the first wave of test merging. I have verified by means of the instrumented run
https://dev.azure.com/dnceng-public/public/_build/results?buildId=145648&view=logs&j=5875517b-40f2-5b27-5b45-8b8aba144595
that Nathan's change passes with my fix.
Thanks
Tomas