Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reflection path for ActivatorUtilities.CreateFactory #81262

Merged
merged 22 commits into from
Jan 30, 2023
Merged

Add reflection path for ActivatorUtilities.CreateFactory #81262

merged 22 commits into from
Jan 30, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 27, 2023

Fixes #81258

@ghost ghost assigned JamesNK Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #81258

Author: JamesNK
Assignees: -
Labels:

area-Extensions-DependencyInjection
Milestone: -

@JamesNK JamesNK removed their assignment Jan 27, 2023
@JamesNK
Copy link
Member Author

JamesNK commented Jan 27, 2023

cc @eerhardt

stephentoub
stephentoub reviewed Jan 27, 2023
View reviewed changes
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Jan 27, 2023
Closed
@JamesNK
Copy link
Member Author

JamesNK commented Jan 27, 2023

All feedback applied.

@JamesNK @jkotas
Update src/libraries/Microsoft.Extensions.DependencyInjection.Abstrac…
274c35f 
…tions/src/ActivatorUtilities.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@JamesNK @jkotas
Update src/libraries/Microsoft.Extensions.DependencyInjection.Abstrac…
fa765c3 
…tions/src/ActivatorUtilities.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
eerhardt
eerhardt approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JamesNK and others added 3 commits January 28, 2023 12:22
davidfowl
davidfowl approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesNK JamesNK merged commit 02682ad into dotnet:main Jan 30, 2023
@JamesNK JamesNK deleted the jamesnk/activatorcreateinstance-dynamiccodesupported branch January 30, 2023 08:57
@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@jkotas jkotas jkotas left review comments

@halter73 halter73 halter73 approved these changes

@davidfowl davidfowl davidfowl approved these changes

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-Extensions-DependencyInjection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use System.Linq.Expressions in ActivatorUtilities.CreateFactory with AOT
6 participants
@JamesNK @halter73 @davidfowl @stephentoub @jkotas @eerhardt