Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete HeapEnableTerminationOnCorruption setting #81343

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 30, 2023

HeapEnableTerminationOnCorruption is enabled by default for subsystem major version 6 that we have set for our binaries. Also delete intranet link to a document that does not exist anymore.

HeapEnableTerminationOnCorruption is enabled by default for subsystem major version 6 that we have set for our binaries. Also delete intranet link to a document that does not exist anymore.
@ghost
Copy link

ghost commented Jan 30, 2023

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

HeapEnableTerminationOnCorruption is enabled by default for subsystem major version 6 that we have set for our binaries. Also delete intranet link to a document that does not exist anymore.

Author: jkotas
Assignees: jkotas
Labels:

area-ILTools-coreclr

Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Jan 30, 2023

@AaronRobinsonMSFT
Copy link
Member

HeapEnableTerminationOnCorruption is enabled by default for subsystem major version 6 that we have set for our binaries.

Currently set at:

# Linker flags
#
set (WINDOWS_SUBSYSTEM_VERSION 6.01)
if (CLR_CMAKE_HOST_ARCH_ARM)
set(WINDOWS_SUBSYSTEM_VERSION 6.02) #windows subsystem - arm minimum is 6.02
elseif(CLR_CMAKE_HOST_ARCH_ARM64)
set(WINDOWS_SUBSYSTEM_VERSION 6.03) #windows subsystem - arm64 minimum is 6.03
endif ()

@jkotas
Copy link
Member Author

jkotas commented Jan 30, 2023

Failure is known issue #75244

@jkotas jkotas merged commit 4d0b619 into dotnet:main Jan 30, 2023
@jkotas jkotas deleted the HeapEnableTerminationOnCorruption branch January 30, 2023 13:39
@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants