[mono][ios] Introduce non-global symbol stripping in MonoAOTCompiler msbuild task #81361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ivanpovazan
reviewed
Jan 31, 2023
|
nit: I would suggested updating the PR's title as stripping became part of Otherwise: LGTM! As a follow-up, we should think about utilising #79721 and possibly strip more from the final binary. |
kotlarmilos
changed the title
Good! I've added tracking issue as a P2. |
rolfbjarne
approved these changes
Feb 2, 2023
|
When stripping non-global symbols from binary, SOD is 13300936 bytes, while when preserving only P/Invokes, SOD is 12699776 bytes. |
|
Failure is #81123. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #80977 by stripping symbols for SOD measurements. It adds an option in the MonoAOTCompiler to extracts non-global symbols from a binary into a separate
.dSYMdirectory.