Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append version to RID only with valid characters #81497

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 1, 2023

This is the init-distro-rid.sh counterpart of 31e4f40.

In amd64/archlinux docker container, the non-portable RID auto-detection (without explicit -p:TargetRid=arch-x64 arg or __DistroRid=arch-x64 env var) looks like this:

Before: __DistroRid: arch.TEMPLATE_VERSION_ID-x64
After: __DistroRid: arch-x64

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 1, 2023
@ghost
Copy link

ghost commented Feb 1, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This is the init-distro-rid.sh counterpart of 31e4f40.

In amd64/archlinux docker container, the non-portable RID auto-detection (without explicit -p:TargetRid=arch-x64 arg or __DistroRid=arch-x64 env var):

Before: __DistroRid: arch.TEMPLATE_VERSION_ID-x64
After: __DistroRid: arch-x64

Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution

Milestone: -

@am11 am11 requested review from tmds and janvorli February 1, 2023 19:42
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tmds
Copy link
Member

tmds commented Feb 2, 2023

lgtm.

For completeness, this isn't used to determine the rid during source-build.
That gets passed down as TargetRid from source-build.
The default is determined by calling RuntimeInformation.RuntimeIdentifier. #80901 should affect that.

@akoeplinger akoeplinger merged commit 52bdf6c into dotnet:main Mar 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants