Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Update arm queues #81712

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Feb 6, 2023

Updating to the latest versions per the suggestion in #81619 (comment). I am using the current latest versions from https://github.com/dotnet/versions, instead of floating versions, to match what we do elsewhere. I am not sure that we would want to use floating versions, especially in our servicing branch.

@ghost
Copy link

ghost commented Feb 6, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Updating to the latest versions per the suggestion in #81619 (comment). I am using the current latest versions from https://github.com/dotnet/versions, instead of floating versions, to match what we do elsewhere. I am not sure that we would want to use floating versions, especially in our servicing branch.

Author: sbomer
Assignees: sbomer
Labels:

area-Infrastructure-coreclr

Milestone: -

@carlossanlop
Copy link
Member

carlossanlop commented Feb 8, 2023

So I merged this fix a couple of hours ago: #81545

It changes the non-existent win10 arm64 helix queue for win11 arm64. I noticed this PR was affected by those non-existent
queues. I also noticed I missed changing the other one, so I'll submit the PR soon. Maybe we should re-run the CI in this PR after that change is merged, to ensure whatever this PR is fixing is properly tested.

Edit: Here's the PR that missed the others: #81808

cc @hoyosjs

@carlossanlop
Copy link
Member

Merged the arm64 Windows queue updates. Closing and reopening this PR.

@carlossanlop carlossanlop reopened this Feb 8, 2023
@sbomer
Copy link
Member Author

sbomer commented Feb 8, 2023

@hoyosjs @agocke any opinion on whether we should use floating versions here?

@agocke
Copy link
Member

agocke commented Feb 8, 2023

Using the floating version seems fine -- I think we're going to be pushed onto that eventually anyway. I would prefer if we had fixed versions and then a system for updating them manually, but that doesn't sound like something that's being invested in.

@carlossanlop
Copy link
Member

Nice, the CI is almost fully green. There's only one queue that might be stuck (and unfortunately, it is arm64). But I'm glad that the main problems got fixed.

By the way, @cston / @adamsitnik / @jozkee, it seems this would fix #81619 #81391 and #81544

@sbomer
Copy link
Member Author

sbomer commented Feb 8, 2023

Thanks, I'll leave the fixed versions for now so that we can get this fixed soon, but next time I touch these queues I'll use floating versions.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this baby merged.

carlossanlop added a commit that referenced this pull request Mar 7, 2023
carlossanlop added a commit that referenced this pull request Mar 8, 2023
…ions instead (#83100)

* Fix superpmi_collect-setup.py helix images to use floating instead

Per the suggestions here: #81712 (comment)

* Update comment at the top

---------

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2023
@sbomer sbomer deleted the updateArmQueues branch November 3, 2023 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants