Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default media type used when 'null' is passed to StringContent #81506 #81722

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

slovely
Copy link
Contributor

@slovely slovely commented Feb 6, 2023

This fixes issue #81506

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 6, 2023
@ghost
Copy link

ghost commented Feb 6, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes issue #81506

Author: slovely
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Feb 6, 2023

CLA assistant check
All CLA requirements met.

@antonfirsov
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@slovely
Copy link
Contributor Author

slovely commented Mar 8, 2023

This seems to be failing due to:

Console log: 'System.Net.Http.Functional.Tests' from job 1608dd3d-afff-484f-9f63-9fe3a5f70161 workitem fc399c4d-4353-44b5-b123-b6e5d9a2f9b3 (windows.amd64.server2022.open.rt) executed on machine a009IRU running Windows-10-10.0.20348-SP0

C:\h\w\B7EF09B6\w\AD35097A\e>taskkill.exe /f /im corerun.exe 
ERROR: The process "corerun.exe" not found.

That is the library that I added a test to, so it's seems too much of a coincidence that it isn't running... but I don't know what I could have done to have broken it I'm afraid!

@wfurt
Copy link
Member

wfurt commented Mar 8, 2023

My guess is that it hits #83110. Offending change was reverted so you can try to rebase from mainline @slovely. That is probably easiest, otherwise we can look at the code dump.

@slovely slovely force-pushed the issue-81506-default-mediatype branch from 6237de8 to 573e2eb Compare March 8, 2023 16:39
@slovely
Copy link
Contributor Author

slovely commented Mar 8, 2023

@dotnet-policy-service agree

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we backport this, I think this is a sufficient minimal fix to unblock people facing the unintentional breaking change. We should revisit the unintentional nullability changes for .NET 8.0, opened #83423 to track that.

@antonfirsov antonfirsov merged commit 86550d7 into dotnet:main Mar 14, 2023
@antonfirsov
Copy link
Member

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4420644720

@karelz
Copy link
Member

karelz commented Mar 21, 2023

@saber-wang @kevinle-1 you upvoted the PR. Did you run into the same problem?
If you did, can you please comment on the original issue #81506? If there are more people hitting it, that would support the backport, otherwise it won't have enough weight to get backported (yet). Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants