Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove test references to archaic Linux versions #81992

Merged
merged 7 commits into from
Feb 12, 2023
Merged

remove test references to archaic Linux versions #81992

merged 7 commits into from
Feb 12, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 11, 2023

follow-up on #34361.
We no longer seems to build and run Drawing tests on Linux.
But GetRecentGdiPlusIsAvailable2 and GetGdiPlusIsAvailableNotRedhat73 seems clearly outdated.
I replaced them with IsWindowsOrAtLeastLibgdiplus6 to be consistent and that seems to work OK on recent Linux distributions. (in case we ever change our minds)

@wfurt wfurt added area-Meta test-enhancement Improvements of test source code labels Feb 11, 2023
@wfurt wfurt self-assigned this Feb 11, 2023
@ghost
Copy link

ghost commented Feb 11, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

follow-up on #34361.
We no longer seems to build and run Drawing tests on Linux.
But GetRecentGdiPlusIsAvailable2 and GetGdiPlusIsAvailableNotRedhat73 seems clearly outdated.
I replaced them with IsWindowsOrAtLeastLibgdiplus6 to be consistent and that seems to work OK on recent Linux distributions. (in case we ever change our minds)

Author: wfurt
Assignees: wfurt
Labels:

area-Meta, test-enhancement
Milestone: -

@jkotas
Copy link
Member

jkotas commented Feb 11, 2023 •
edited
Loading

We have deleted Systém.Drawing support fór Unix that used to depend on libgdiplus. All gdiplus related conditions can be deleted.

@build-analysis build-analysis bot mentioned this pull request Feb 12, 2023
Closed
@carlossanlop
Copy link
Member

@wfurt does this need to be backported to 7.0 and 6.0? If yes, then this is a friendly reminder that Code Complete for the March Servicing Release is tomorrow Monday 13th EOD.

@jkotas
Copy link
Member

jkotas commented Feb 12, 2023

This is cleanup PR. It is not a servicing candidate.

@jkotas jkotas merged commit 2749ee1 into dotnet:main Feb 12, 2023
@wfurt
Copy link
Member Author

wfurt commented Feb 12, 2023

thanks for the help @jkotas.

@wfurt wfurt deleted the PlatformDetection branch February 12, 2023 22:39
ViktorHofer pushed a commit to dotnet/winforms that referenced this pull request Feb 13, 2023
@wfurt
remove test references to archaic Linux versions (dotnet/runtime#81992)
c598035 
* remove test references to archaic Linux versions

* Fix tests on Nano

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Commit migrated from dotnet/runtime@2749ee1
@vcsjones vcsjones mentioned this pull request Feb 15, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

Assignees

@wfurt wfurt

Labels
area-Meta test-enhancement Improvements of test source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wfurt @jkotas @carlossanlop