-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pool provider template reference #82452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, make sure to check in on any pipelines not run as part of PR validation after it merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add the variable template in the pipeline-with-resources.yml
template instead of in each job template? Not sure if it makes an appreciable difference.
@jkoritzinsky I tried, the yml fails to expand sadly. something already defines a variable scope globally. |
Dang. Let's just go with this then. |
There are some... compromises... in the eng/common folder's usage of the same for the same reason. I'm just happy it can work at all. |
verifies the internal build used the variables were properly expanded. |
/azp run runtime-libraries enterprise-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
Use template to determine pool provider to use.
The provider can't be expanded in the pipeline-with-resources step as the expansion breaks once global variables are consolidated. All variables end up in the global scope correctly, but several expansion points are expanded before assignment - particularly the ones at the pipeline scope - meaning that several parameters derived from them are empty and cause issues in further expansion decisions.