-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Fixed the 3rd argument for TypedArray.fill() #82480
Conversation
`TypedArray.fill()` expects `end` as the 3rd argument.
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAccording to
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Hm, you're right about the mdn docs, but the change caused a ton of test failures. Maybe it's some sort of infrastructure problem. I'll re-run the tests tomorrow. |
Strange, this is on chrome
|
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4258087063 |
@shin1m thank you so much for finding this and contributing a fix. |
@lewing backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fixed the 3rd argument for TypedArray.fill().
Using index info to reconstruct a base tree...
M src/mono/wasm/runtime/memory.ts
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/runtime/memory.ts
CONFLICT (content): Merge conflict in src/mono/wasm/runtime/memory.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fixed the 3rd argument for TypedArray.fill().
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@lewing an error occurred while backporting to release/7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Thank you for reviewing. |
According to
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/fill
,
TypedArray.fill()
expectsend
as the 3rd argument.