Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasi] Misc fixes #82569

Merged
merged 8 commits into from
Feb 24, 2023
Merged

[wasi] Misc fixes #82569

merged 8 commits into from
Feb 24, 2023

Conversation

radical
Copy link
Member

@radical radical commented Feb 24, 2023

  • Enable assert messages on CI, to help with debugging
  • Fix building some test projects that reference .ilproj, by correctly setting the RID used for those

@radical radical added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Feb 24, 2023
@ghost ghost assigned radical Feb 24, 2023
@ghost
Copy link

ghost commented Feb 24, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Enable assert messages on CI, to help with debugging
  • Fix building some test projects that reference .ilproj, by correctly setting the RID used for those
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono, os-wasi

Milestone: -

@radical
Copy link
Member Author

radical commented Feb 24, 2023

/azp run runtime-wasm-optional

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

.. supported.

```
[00:52:00] fail: [FAIL] System.Formats.Cbor.Tests.CborWriterTests.CoseKeyHelpers_ECDsaExportCosePublicKey_HappyPath(expectedHexEncoding: "a501020326200121582065eda5a12577c2bae829437fe33870"..., hexQx: "65eda5a12577c2bae829437fe338701a10aaa375e1bb5b5de1"..., hexQy: "1e52ed75701163f7f9e40ddf9f341b3dc9ba860af7e0ca7ca7"..., hashAlgorithmName: "SHA256", curveFriendlyName: "ECDSA_P256")
[00:52:00] info: System.PlatformNotSupportedException : System.Security.Cryptography is not supported on this platform.
[00:52:00] info:    at System.Security.Cryptography.HashAlgorithmName..ctor(String name)
[00:52:00] info:    at System.Formats.Cbor.Tests.CborWriterTests.CoseKeyHelpers_ECDsaExportCosePublicKey_HappyPath(String expectedHexEncoding, String hexQx, String hexQy, String hashAlgorithmName, String curveFriendlyName)
[00:52:00] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, IntPtr* args)
[00:52:00] info:    at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
```
@radical
Copy link
Member Author

radical commented Feb 24, 2023

Failures are known issues, and unrelated.

@radical radical merged commit 4dd649b into dotnet:main Feb 24, 2023
@radical radical deleted the misc-wasi-fixes branch February 24, 2023 23:31
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants