Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm support to IndexOfAnyAsciiSearcher #83122

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

stephentoub
Copy link
Member

I cherry-picked @MihaZupan's commit and just substituted in the new methods @radekdoulik merged.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned stephentoub Mar 8, 2023
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can improve it once I will add arithmetic right shift to packed simd class.

@stephentoub
Copy link
Member Author

stephentoub commented Mar 8, 2023

Thanks, @radekdoulik. Are you ok merging this one and the json one and then seeing where everything lands after that?

@radekdoulik
Copy link
Member

Yes, I am looking forward to that. The SIMD is now enabled by default for wasm AOT builds, so we should see changes in the dotnet/perf-autofiling-issues.

@stephentoub stephentoub merged commit a1d1a8d into dotnet:main Mar 8, 2023
@MihaZupan
Copy link
Member

MihaZupan commented Mar 8, 2023

Some rough numbers I'm seeing in a stopwatch-style benchmark, IndexOfAnyAsciiByteValues Length=1000 goes from ~16 to ~1.5 microseconds.
On the same machine with regular X86, it takes ~310 ns with AVX2 and ~500 with Vector128 paths.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants