[WIP][browser] Split into smaller es6 modules #83364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailswork in progress
|
maraf
reviewed
Mar 14, 2023
|
|
||
| let consoleWebSocket: WebSocket; | ||
|
|
||
| function setup_proxy_console(id: string, console: Console, origin: string): void { |
There was a problem hiding this comment.
Do we really need this in the loader?
lambdageek
reviewed
Mar 14, 2023
Comment on lines
+431
to
+449
| const runtimeModule: RuntimeModuleAPI = await modulePromises[0]; | ||
| const { initializeImportsAndExports } = runtimeModule; | ||
|
|
||
| const { default: emscriptenModule } = await modulePromises[1]; |
There was a problem hiding this comment.
Suggested change
| const runtimeModule: RuntimeModuleAPI = await modulePromises[0]; | |
| const { initializeImportsAndExports } = runtimeModule; | |
| const { default: emscriptenModule } = await modulePromises[1]; | |
| const [runtimeModule, coreModule] = await Promise.all (modulesPromises); | |
| const { initializeImportsAndExports} = runtimeModule; | |
| const { default: emscriptenModule } = coreModule; |
pavelsavara
force-pushed
the
browser_modules
branch
from
5f8353f
to
cc815bc
Compare
pavelsavara
added
NO-MERGE
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress