Delete Microsoft.Windows.Compatibility from runtime #84013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet/winforms#8909 moves the M.W.C package into windowsdesktop. Deleting the source from runtime and the package versions that aren't used anymore.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsdotnet/winforms#8909 moves the M.W.C package into windowsdesktop. Deleting the source from runtime and the package versions that aren't used anymore.
|
carlossanlop
approved these changes
Mar 28, 2023
| <SystemRuntimeInteropServicesRuntimeInformationVersion>4.3.0</SystemRuntimeInteropServicesRuntimeInformationVersion> | ||
| <SystemSecurityAccessControlVersion>6.0.0</SystemSecurityAccessControlVersion> | ||
| <SystemSecurityCryptographyAlgorithmsVersion>4.3.1</SystemSecurityCryptographyAlgorithmsVersion> | ||
| <SystemSecurityCryptographyCngVersion>5.0.0</SystemSecurityCryptographyCngVersion> | ||
| <SystemSecurityCryptographyOpenSslVersion>5.0.0</SystemSecurityCryptographyOpenSslVersion> | ||
| <SystemSecurityPrincipalWindowsVersion>5.0.0</SystemSecurityPrincipalWindowsVersion> | ||
| <SystemSecurityPermissionsVersion>7.0.0</SystemSecurityPermissionsVersion> | ||
| <SystemServiceModelPrimitivesVersion>4.9.0</SystemServiceModelPrimitivesVersion> |
There was a problem hiding this comment.
Are these the packages you mention in the PR description?
and the package versions that aren't used anymore.
I am missing context. Are these related to M.W.C? Or just removing them as an unrelated improvement?
There was a problem hiding this comment.
Those versions were referenced only by M.W.C. Now that M.W.C doesn't exist in runtime anymore, delete them as they are dead code.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77557
Blocked by dotnet/windowsdesktop#3516
dotnet/windowsdesktop#3516 moves the M.W.C package into windowsdesktop. Deleting the source from runtime and the package versions that aren't used anymore.