Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction of three code comments in Dictionary.cs #84128

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Correction of three code comments in Dictionary.cs #84128

merged 1 commit into from
Mar 31, 2023

Conversation

theodorzoulias
Copy link
Contributor

Three code comments refer to the EqualityComparer<TValue>.Default, instead of the correct EqualityComparer<TKey>.Default.

@theodorzoulias
Correct three code comments in Dictionary.cs
de0e2cc 
Three code comments refer to the EqualityComparer<TValue>.Default, instead of the correct EqualityComparer<TKey>.Default.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 30, 2023
@ghost
Copy link

ghost commented Mar 30, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Three code comments refer to the EqualityComparer<TValue>.Default, instead of the correct EqualityComparer<TKey>.Default.

Author: theodorzoulias
Assignees: -
Labels:

area-System.Collections, community-contribution
Milestone: -

danmoseley
danmoseley approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@build-analysis build-analysis bot mentioned this pull request Mar 30, 2023
Closed
@jkotas jkotas merged commit 2323fc8 into dotnet:main Mar 31, 2023
@theodorzoulias theodorzoulias deleted the patch-1 branch March 31, 2023 02:14
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theodorzoulias @stephentoub @danmoseley @jkotas