Fix incorrect covariant returns tests #84615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention of the methods is to override a base method, but the signature is wrong so they introduce a new slot instead. The test is not testing what it wanted to tests (that the override is not reachable) because we would never call this new slot method. `!0` and `!1` corresponds to `UNUSED1` and `UNUSED2`.
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
MichalStrehovsky
added
area-TypeSystem-coreclr
and removed
needs-area-label
|
Thanks!! |
VSadov
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of the methods is to override a base method, but the signature is wrong so they introduce a new slot instead. The test is not testing what it wanted to tests (that the override is not reachable) because we would never call this new method through a virtual call.
!0and!1corresponds toUNUSED1andUNUSED2.Peeled off from #84404 so that I can get a review.
Cc @dotnet/ilc-contrib