Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [mono] Add metadata update for overrides (backport #85182) #85259

Merged

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Apr 24, 2023

Backports #85182

Customer impact

Customer will be able to use hot reload with async method when using Mono runtime

Testing

Tested on CI and previous failed test passed.

Risk

Low. We have the same kind of "binary search, the linear search" for other tables in the metadata update.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label Apr 24, 2023
@ghost ghost assigned fanyang-mono Apr 24, 2023
@fanyang-mono fanyang-mono added the Servicing-consider Issue for next servicing release review label Apr 24, 2023
@fanyang-mono
Copy link
Member Author

CI failures were seen on release/7.0 runs as well, i.e. https://dev.azure.com/dnceng-public/public/_build/results?buildId=242232&view=results. They are not related to this PR.

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 25, 2023
@rbhanda rbhanda modified the milestones: 7.0.x, 7.0.7 Apr 25, 2023
@fanyang-mono fanyang-mono merged commit f16c731 into dotnet:release/7.0-staging Apr 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants