Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Mono LLVM legs on the CBL-Mariner images, but run the AOTing steps on CentOS Stream 8 with binutils #85273

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

jkoritzinsky
Copy link
Member

We want to move off of using CentOS 7 images for our builds, but Mono's AOT tooling uses binutils tools for its AOT process. We can't built Mono on CentOS Stream 8 images as that introduces too high of a glibc dependency. This PR moves the product build steps to use our CBL-Mariner images that set up the right libc dependency, while setting up the AOT legs to use our CentOS Stream 8 image that provides the binutils tools on a supported base image.

Replaces #84727

@ghost
Copy link

ghost commented Apr 24, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

We want to move off of using CentOS 7 images for our builds, but Mono's AOT tooling uses binutils tools for its AOT process. We can't built Mono on CentOS Stream 8 images as that introduces too high of a glibc dependency. This PR moves the product build steps to use our CBL-Mariner images that set up the right libc dependency, while setting up the AOT legs to use our CentOS Stream 8 image that provides the binutils tools on a supported base image.

Replaces #84727

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! LGTM if it works.

@jkoritzinsky
Copy link
Member Author

All failures are known and the job this change was supposed to fix passed!

@jkoritzinsky jkoritzinsky merged commit ad59672 into dotnet:main Apr 25, 2023
@jkoritzinsky jkoritzinsky deleted the llvmaot-ssc branch April 25, 2023 03:33
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants