Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set BuildAsStandalone for gcstress test builds #85284

Closed
wants to merge 10 commits into from

Conversation

markples
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2023
@ghost ghost assigned markples Apr 25, 2023
@markples markples added test-enhancement Improvements of test source code and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 25, 2023
@markples

This comment was marked as duplicate.

@azure-pipelines

This comment was marked as duplicate.

@markples
Copy link
Member Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Member Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Member Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Member Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Member Author

markples commented May 2, 2023

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Member Author

markples commented May 2, 2023

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Member Author

markples commented May 3, 2023

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Member Author

markples commented May 5, 2023

I'm going back to trying to get merging to work better (e.g., #85040). This has been painful and isn't there yet. There are a few fundamental points:

  • A test needs to change between OutputType Exe vs Library for a merged test vs one with RequireProcessIsolation (or in BuildAsStandalone mode). While theoretically this shouldn't be different between RPI and BAS, I've hit a lot of issues messing around with it. This is how we've ended up in a situation where RPI works (only) when marked on tests and BAS works (only) as a global setting. This is relevant to the idea below of trying to run a few merged groups in a BAS build.
  • We have some huge projects (such as JIT\HardwareIntrinsics\Arm\AdvSimd.Arm64\AdvSimd.Arm64_r.csproj). In merged test groups, the individual tests within this project can be striped to multiple helix jobs. In the old style, this test has a single entry point that runs everything, and it times out under gcstress.

I don't think investing in striping in BAS is the right direction as the main reason for BAS is to be simpler than merged groups, and I don't think investing in special cases in the msbuild BAS support is the right thing to do (or then maintain). Maybe after efforts fail again with merged groups I'll change my mind again.

@markples markples closed this May 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant