[wasm] Wasm.Build.Tests - use the new sdk with templates #85498
Conversation
radical
commented
Apr 28, 2023
radical
commented
- based on changes from [browser] Use Wasm SDK in browser template #85311, and [wasm] test sdk.pack in workload #85408
radical
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="$(RepoTasksDir)Microsoft.NET.Sdk.WebAssembly.Pack.Tasks\Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.csproj" /> | |||
| <PackageFile Include="build\*.props;build\*.targets;build\*.web.config" TargetPath="build" /> | |||
| <PackageFile Include="Sdk\*.props;Sdk\*.targets;Sdk\*.web.config" TargetPath="Sdk" /> | |||
There was a problem hiding this comment.
This didn't worked for me. How is it that it works now? Will it still work in blazor without workload?
| @@ -178,6 +179,10 @@ | |||
| "kind": "Sdk", | |||
| "version": "${PackageVersion}" | |||
| }, | |||
| "Microsoft.NET.Sdk.WebAssembly.Pack": { | |||
There was a problem hiding this comment.
What is the consequence of this change? Will it still work in blazor without workload?
| import { dotnet } from './_framework/dotnet.js' | ||
|
|
||
| const { setModuleImports, getAssemblyExports, getConfig } = await dotnet | ||
| .withStartupOptions({}) |
There was a problem hiding this comment.
I'm tackling with this in my original PR. It shouldn't be in the template
There was a problem hiding this comment.
I can remove this from this draft PR when your changes land.
Anything needed to update the wasmbrowser template to use the wasm sdk.
Do you mean #85311 ? The template, and the WBT parts should get covered here. Anything else that you want to change/fix like the |
| <!-- WASM projects defaults to browser-wasm --> | ||
| <RuntimeIdentifier Condition="'$(RuntimeIdentifier)' == ''">browser-wasm</RuntimeIdentifier> | ||
| <UseMonoRuntime>true</UseMonoRuntime> | ||
|
|
There was a problem hiding this comment.
This file has a slight change in SDK dotnet/sdk#32170
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
