ProcessTests: allow WorkingSet to be zero just after launching the process. #85649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocess. The WorkingSet tests fail on Fedora 38+ because a zero working set value is observed just after the process start.
ghost
added
the
community-contribution
This was referenced May 2, 2023
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process Issue DetailsFixes #83129. The WorkingSet tests fail on Fedora 38+ because a zero working set value is observed just after the process start. @dotnet/area-system-diagnostics-process ptal. cc @omajid
|
adamsitnik
reviewed
May 11, 2023
There was a problem hiding this comment.
Big thanks for making our test suite ready for the newest Linux kernel @tmds!
I left two comments, my main concern is catching only exception specific for this case.
|
@adamsitnik I've addressed your feedback, ptal. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83129.
The WorkingSet tests fail on Fedora 38+ because a zero working set value is observed just after the process start.
@dotnet/area-system-diagnostics-process ptal.
cc @omajid