Ensure Vector2/3/4, Quaternion, and Plane don't have a false dependency on Vector<T> #86481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsExtracted from #85551
|
tannergooding
commented
May 19, 2023
| @@ -8332,10 +8332,7 @@ NamedIntrinsic Compiler::lookupNamedIntrinsic(CORINFO_METHOD_HANDLE method) | |||
| CORINFO_SIG_INFO sig; | |||
| info.compCompHnd->getMethodSig(method, &sig); | |||
|
|
|||
| int sizeOfVectorT = getSIMDVectorRegisterByteLength(); | |||
There was a problem hiding this comment.
This is what gave the "false dependency" on all intrinsic APIs under System.Numerics.
It gave a query that was compExactlyDependsOn(InstructionSet_AVX2) which in turn meant it opted out of any default pre-jit support.
The check was instead moved down to APIs on Vector<T> itself -or- APIs that took/returned Vector<T> elsewhere.
It does not include all APIs on System.Numerics.Vector as we have a couple extension methods for Vector2/3/4, Quaternion, and Plane that live on the same class
tannergooding
force-pushed
the
prefer-vector-width-3
branch
from
8c0caf6
to
038796a
Compare
EgorBo
approved these changes
May 19, 2023
3 tasks
|
Failure is dotnet/arcade#13625 and reproducing on other PRs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #85551