Disable mark list optimization if we hit a per region mark list overflow #86508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsFixes microsoft/FASTER#835 In case the mark list is overflowed when we
|
Maoni0
requested changes
May 23, 2023
ghost
added
the
needs-author-action
PeterSolMS
reviewed
May 23, 2023
cshung
force-pushed
the
public/mark-list-overflow
branch
from
2812a50
to
e23f73d
Compare
ghost
removed
the
needs-author-action
|
this actually compiles? |
cshung
force-pushed
the
public/mark-list-overflow
branch
from
e23f73d
to
c82a4fe
Compare
cshung
added a commit
to cshung/runtime
that referenced
this pull request
Jun 9, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/FASTER#835
In case the mark list is overflowed when we
get_region_mark_list, we have to disable the optimization, otherwise, we will miss marking live objects and cause heap corruption.