Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hot reload][mono] Implement support for adding static and instance fields to generic classes #87285

Merged
merged 12 commits into from
Jun 16, 2023

Conversation

lambdageek
Copy link
Member

@lambdageek lambdageek commented Jun 8, 2023

Fixes #86111

dotnet/roslyn#68293 we get an error if we
add a generic field and try to use it during the same edit.
workaround is to do two separate edits
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label Jun 8, 2023
@ghost ghost assigned lambdageek Jun 8, 2023
@lambdageek
Copy link
Member Author

cc @mikelle-rogers coreclr doesn't like the new test

@lambdageek lambdageek changed the title [hot reload][mono] Implement support for adding static fields to generic classes [hot reload][mono] Implement support for adding static and instance fields to generic classes Jun 8, 2023
@lambdageek
Copy link
Member Author

Also found an issue where mono does loads of added valuetype fields incorrectly. That warrants its own non-generic test (the existing tests only try small primitive types, not structs like DateTime).

@lambdageek
Copy link
Member Author

@fanyang-mono please take a look

Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if you need to update hot_reload_get_capabilities for this new capability?

@lambdageek
Copy link
Member Author

LGTM! I wonder if you need to update hot_reload_get_capabilities for this new capability?

yes! thank you!

@lambdageek lambdageek merged commit 71ee9ea into dotnet:main Jun 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hot reload] Support the GenericAddFieldToExistingType capability in Mono
3 participants