[release/7.0-staging] [mono] permission denied when reading a jitdump file #87427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
|
@fanyang-mono @lambdageek @vargaz Today is code complete for the July servicing release. Please get a Tactics approval, sign-off, confirm the CI failures are unrelated, and merge before EOD if you'd like this to be included in the release. |
This was referenced Jun 13, 2023
|
CI failures are not related to this PR. |
lambdageek
approved these changes
Jun 13, 2023
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tactics has approved this. |
fanyang-mono
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #82520 to release/7.0-staging
/cc @fanyang-mono @saitama951
Customer Impact
With this change, Mono customer could get a perf report with Mono runtime provided jitdump information. Without this change, perf had trouble reading the log files that Mono provided.
Testing
Verified manually locally and passed CI testing.
Risk
None. This is a very minor bug fixing to the Mono jitdump feature, which was designed for performance diagnostics.