Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0-staging] dotnet.exe prints error messages to console when launched with empty DOTNET_MULTILEVEL_LOOKUP #87734

Merged
merged 10 commits into from
Jun 26, 2023
Merged

[release/7.0-staging] dotnet.exe prints error messages to console when launched with empty DOTNET_MULTILEVEL_LOOKUP #87734

merged 10 commits into from
Jun 26, 2023

Commits on Jun 17, 2023

  1. dotnet.exe prints error messages to console when launched with empty … 

    …DOTNET_MULTILEVEL_LOOKUP
    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    8e6e825 View commit details
    Browse the repository at this point in the history

  2. reuse err variable instead of invoking GetLastError another time 

    Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
    @pedrobsaila @vitek-karas
    2 people authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    dbcde13 View commit details
    Browse the repository at this point in the history

  3. another useless call to GetLastError

    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    279a613 View commit details
    Browse the repository at this point in the history

  4. add tests

    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    0856c2d View commit details
    Browse the repository at this point in the history

  5. fix spacing

    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    565116b View commit details
    Browse the repository at this point in the history

  6. add asserts to another test

    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    f702c6c View commit details
    Browse the repository at this point in the history

  7. delete empty instruction

    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    45dcab0 View commit details
    Browse the repository at this point in the history

  8. use EnableTracingAndCaptureOutputs

    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    e30855d View commit details
    Browse the repository at this point in the history

  9. check just that no error is logged

    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    7193ae2 View commit details
    Browse the repository at this point in the history

  10. rollback change correctly

    @pedrobsaila
    pedrobsaila authored and github-actions committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    ea496fb View commit details
    Browse the repository at this point in the history