Using stackalloc instead of new byte[x] on Streams #88303

Poppyto · 2023-07-02T22:07:58Z

Replace new[] allocations with stackalloc for one byte array in different Stream classes.
I don't think there will be a big performance change at the CPU level but it will always be a gain on the garbage collector

This reverts commit 449fdde.

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs

ghost · 2023-07-02T22:16:04Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Replace new[] allocations with stackalloc for one byte array in different Stream classes.
I don't think there will be a big performance change at the CPU level but it will always be a gain on the garbage collector

Author:	Poppyto
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

stephentoub · 2023-07-02T22:28:09Z

Thanks, but these are all async methods accepting Memory, not Span. You can't pass a stackalloc'd span to them. This will not compile.

Poppyto · 2023-07-02T22:44:38Z

Thanks, but these are all async methods accepting Memory, not Span. You can't pass a stackalloc'd span to them. This will not compile.

How could I missed that ! Fixed :) - rollback for DecompressionHandler - Other changes seem fine.

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/DecompressionHandler.cs

src/libraries/System.Private.CoreLib/src/System/IO/Stream.cs

src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs

teo-tsirpanis

You can use the span constructors introduced in .NET 7 instead of stackalloc.

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs

…tem/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs replace Span by ReadOnlySpan Co-authored-by: Michał Petryka <35800402+MichalPetryka@users.noreply.github.com>

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs

stephentoub

Other than my remaining comments, LGTM.

…tem/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>

Poppyto added 7 commits July 2, 2023 01:20

first XOR Linq implemetation

449fdde

replace classic allocation by stack allocation for ReadByte

980d208

replace classic allocation by stack allocation for ReadByte & WriteByte

1846980

replace classic allocation by stack allocation for ReadByte/CopyToAsync

d56f48a

add missing ConfigureAwait(false) on ReadAsync

a5ca7c8

replace classic allocation by stack allocation for ReadByte/WriteByte

c40cea4

Revert "first XOR Linq implemetation"

10d9882

This reverts commit 449fdde.

dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 2, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 2, 2023

Poppyto changed the title ~~Using stackalloc instead of new byte[x]~~ Using stackalloc instead of new byte[x] on Streams Jul 2, 2023

filipnavara reviewed Jul 2, 2023

View reviewed changes

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Outdated Show resolved Hide resolved

filipnavara requested review from stephentoub and adamsitnik July 2, 2023 22:15

filipnavara added area-System.IO and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 2, 2023

Poppyto added 3 commits July 3, 2023 00:38

indent fix

f208335

rollback stackalloc on async methods

6125271

missing char

b3291fc

stephentoub reviewed Jul 2, 2023

View reviewed changes

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/DecompressionHandler.cs Outdated Show resolved Hide resolved

stephentoub reviewed Jul 2, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/Stream.cs Outdated Show resolved Hide resolved

stephentoub reviewed Jul 2, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/Stream.cs Outdated Show resolved Hide resolved

fix ConfigureAwait

74d02fe

stephentoub reviewed Jul 2, 2023

View reviewed changes

src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs Outdated Show resolved Hide resolved

Poppyto added 4 commits July 3, 2023 01:06

rollback ReadByte optim (degrade perfs)

707fcf3

variablename fix

4f9d3b4

missing comment

af391ab

rollback Stream allocations

2af0c8e

missing arguments

6cc3122

stephentoub reviewed Jul 2, 2023

View reviewed changes

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Outdated Show resolved Hide resolved

teo-tsirpanis reviewed Jul 3, 2023

View reviewed changes

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Outdated Show resolved Hide resolved

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Outdated Show resolved Hide resolved

Poppyto added 3 commits July 4, 2023 23:06

add Write(ReadOnlySpan<byte>) method

ca86d8b

better initialize Span

ba3511e

add CRLF

cad94f5

This was referenced Jul 4, 2023

Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488

Open

LibraryImportGenerator.Unit.Tests crashed in CI #87951

Closed

stephentoub requested changes Jul 5, 2023

View reviewed changes

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 5, 2023

Poppyto added 3 commits July 5, 2023 07:41

resolve comments

3a0e121

simplification call method Write

00544fb

Merge branch 'dotnet:main' into streamStackAlloc

6ebec71

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 5, 2023

MichalPetryka reviewed Jul 5, 2023

View reviewed changes

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Outdated Show resolved Hide resolved

Poppyto and others added 2 commits July 5, 2023 13:19

Update src/libraries/System.Private.DataContractSerialization/src/Sys…

2ea5c7c

…tem/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs replace Span by ReadOnlySpan Co-authored-by: Michał Petryka <35800402+MichalPetryka@users.noreply.github.com>

remove trailing whitespace

213ab21

Poppyto requested a review from stephentoub July 6, 2023 05:23

adamsitnik added area-Serialization and removed area-System.IO labels Aug 3, 2023

stephentoub reviewed Aug 9, 2023

View reviewed changes

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Outdated Show resolved Hide resolved

stephentoub reviewed Aug 9, 2023

View reviewed changes

...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Outdated Show resolved Hide resolved

stephentoub approved these changes Aug 9, 2023

View reviewed changes

Poppyto and others added 2 commits August 9, 2023 18:37

Update src/libraries/System.Private.DataContractSerialization/src/Sys…

a520eef

…tem/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>

Update src/libraries/System.Private.DataContractSerialization/src/Sys…

ce38130

…tem/Runtime/Serialization/Json/JsonEncodingStreamWrapper.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>

build-analysis bot mentioned this pull request Aug 9, 2023

Tests.System.TimeProviderTests.TestProviderTimer test failure #87477

Closed

StephenMolloy merged commit d87964d into dotnet:main Aug 11, 2023
98 of 99 checks passed

ghost locked as resolved and limited conversation to collaborators Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using stackalloc instead of new byte[x] on Streams #88303

Using stackalloc instead of new byte[x] on Streams #88303

Poppyto commented Jul 2, 2023

ghost commented Jul 2, 2023

stephentoub commented Jul 2, 2023

Poppyto commented Jul 2, 2023

teo-tsirpanis left a comment

stephentoub left a comment

Using stackalloc instead of new byte[x] on Streams #88303

Using stackalloc instead of new byte[x] on Streams #88303

Conversation

Poppyto commented Jul 2, 2023

ghost commented Jul 2, 2023

stephentoub commented Jul 2, 2023

Poppyto commented Jul 2, 2023

teo-tsirpanis left a comment

Choose a reason for hiding this comment

stephentoub left a comment

Choose a reason for hiding this comment