-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-staging][wasm][debugger] Improve debugger performance #88602
[release/7.0-staging][wasm][debugger] Improve debugger performance #88602
Conversation
Tagging subscribers to this area: @thaystg Issue DetailsOnly try to use the debugger protocol if HttpClient.GetByteArrayAsync does not work. Customer Impact Testing: Risk
|
Co-authored-by: Ankit Jain <radical@gmail.com>
else | ||
{ | ||
foreach (string file_name in loaded_files) | ||
catch (Exception e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check for more specific exception type(s)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, the retry should be if either of the two tasks fail, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it logger.LogDebug if it goes down this new path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont't think so, only if it fails in the retry process too, or if tryUseDebuggerProtocol is disabled.
Approved by email. |
Only try to use the debugger protocol if HttpClient.GetByteArrayAsync does not work.
Customer Impact:
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1772588
When the customer has a lot of assemblies in its solution the debugger takes a long time to attach.
Testing:
Launching the app and trying to debug. It reduces the attachment time by 2x, like from 4 seconds to 2 seconds.
Risk:
Low, only using the HttpClient.GetByteArrayAsync as it was used before, and retry with the debugger protocol if it fails.