Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos12 machines in official build #88793

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

agocke
Copy link
Member

@agocke agocke commented Jul 12, 2023

Scout out macos 12 images in official build only.

Scout out macos 12 images in official build only.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 12, 2023
@ghost ghost assigned agocke Jul 12, 2023
Temporarily use macos12 in PR to check that everything works.
@agocke
Copy link
Member Author

agocke commented Jul 12, 2023

Also flighting this in PR first.

vmImage: 'macos-11'

${{ if and(in(parameters.osGroup, 'osx', 'maccatalyst', 'ios', 'iossimulator', 'tvos', 'tvossimulator'), ne(variables['System.TeamProject'], 'public')) }}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use ${{ else }} here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, is that new? That has to be new.

@agocke
Copy link
Member Author

agocke commented Jul 13, 2023

Official build passed, merging.

@agocke agocke merged commit 33ba157 into dotnet:main Jul 13, 2023
171 of 177 checks passed
@agocke agocke deleted the use-macos-12-on-official branch July 13, 2023 05:41
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants