Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move full facade assemblies into src/libraries/shims #89184

Merged
merged 6 commits into from
Jul 21, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
<ForceBuildMobileManifests Condition="'$(DotNetBuildFromSource)' == 'true'">true</ForceBuildMobileManifests>
</PropertyGroup>

<!-- TODO: Revert. This is just so that CI runs against all legs... -->
ViktorHofer marked this conversation as resolved.
Show resolved Hide resolved

<PropertyGroup Label="CalculateTargetOS">
<_hostOS>linux</_hostOS>
<_hostOS Condition="$([MSBuild]::IsOSPlatform('OSX'))">osx</_hostOS>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
<Compile Include="System\Security\AccessControl\RegistrySecurity.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Buffers" />
<Reference Include="System.Collections" />
<Reference Include="System.Memory" />
<Reference Include="System.Runtime" />
Expand Down
287 changes: 0 additions & 287 deletions src/libraries/System.AppContext/System.AppContext.sln

This file was deleted.

This file was deleted.

11 changes: 0 additions & 11 deletions src/libraries/System.AppContext/ref/System.AppContext.csproj

This file was deleted.

9 changes: 0 additions & 9 deletions src/libraries/System.AppContext/src/System.AppContext.csproj

This file was deleted.

287 changes: 0 additions & 287 deletions src/libraries/System.Buffers/System.Buffers.sln

This file was deleted.

7 changes: 0 additions & 7 deletions src/libraries/System.Buffers/ref/System.Buffers.Forwards.cs

This file was deleted.

9 changes: 0 additions & 9 deletions src/libraries/System.Buffers/ref/System.Buffers.csproj

This file was deleted.

11 changes: 0 additions & 11 deletions src/libraries/System.Buffers/src/System.Buffers.csproj

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

431 changes: 0 additions & 431 deletions src/libraries/System.Diagnostics.Debug/System.Diagnostics.Debug.sln

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
<CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies>
</PropertyGroup>
<ItemGroup>
<DefaultReferenceExclusion Include="System.Diagnostics.Debug" />
<DefaultReferenceExclusion Include="System.Runtime.Extensions" />
<DefaultReferenceExclusion Include="System.Collections" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for these and the change? Is it just to avoid duplicate types?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. The default reference exclusion was necessary when these assemblies still contained types and weren't pure facade assemblies because of duplicate types.

<ProjectReference Include="$(CoreLibProject)" />
<ProjectReference Include="$(LibrariesProjectRoot)System.Runtime\src\System.Runtime.csproj" />
Expand Down
Loading
Loading