[mono][jit] Enabled Ctor, Set_Item and Get_Item Vector4 intrinsics for miniJIT on ARM64 #89501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
fanyang-mono
approved these changes
Jul 26, 2023
| MONO_EMIT_NEW_COND_EXC (cfg, GE_UN, "ArgumentOutOfRangeException"); | ||
| } | ||
|
|
||
| if (COMPILE_LLVM (cfg)) { |
There was a problem hiding this comment.
I believe that there is something that we could do to simplify this code path. Please open an issue to track it. You could say something like "Merge LLVM and non-llvm code path in emit_vector_2_3_4" in the issue.
|
Looks like the test failures on |
jandupej
requested changes
Jul 27, 2023
ghost
added
the
needs-author-action
Signed-off-by: Vlad <vladionescu1399@gmail.com>
ghost
removed
the
needs-author-action
They were caused by not handling non constant index cases for get and set item. |
jandupej
approved these changes
Jul 28, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #86957.