Add [DebuggerGuidedStepThrough] to new invoker methods #89596
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsAdd these missing attributes to make the newly added invoker APIs consistent with the standard invoke APIs in NativeAOT. CoreClr info: using "Just My Code" does work with the newly added invoker APIs for CoreClr; that is, you can step into the invoked method. With "Just My Code" off, however, the stepped-into method is hit-or-miss for both the new invoker APIs as well as the existing ones (one of the internal framework methods will be stepped into). We could add
|
|
Does this change cause any observable behavior under unmanaged debugger that's the only debugging story for native AOT at the moment? |
Native AOT currently doesn't respect this (the attribute is a leftover from .NET Native). It should be possible to make this work on Windows with 0xF00F00/0xFEEFEE magic line numbers, but I'm not aware of a way to make this work outside Windows so the priority of implementing this is lower right now since we can't make it work crossplat. |
|
@MichalStrehovsky feel free to close this PR if it doesn't matter - I just created this PR for consistency. |
I don't mind either way - it's possible we'll want to fix this at some point. But to merge this, uses in ConstructorInvoker.cs will need to be updated to call PreviousCallContainsDebuggerStepInCode, similar to how it's called in MethodInvoker.cs. |
ghost
locked as resolved and limited conversation to collaborators
Add these missing attributes to make the newly added invoker APIs consistent with the standard invoke APIs in NativeAOT.
CoreClr info: using "Just My Code" does work with the newly added invoker APIs for CoreClr; that is, you can step into the invoked method. With "Just My Code" off, however, the stepped-into method is hit-or-miss for both the new invoker APIs as well as the existing ones (one of the internal framework methods will be stepped into). We could add
[DebuggerHidden]and[DebuggerStepThrough]to more methods to make step-in work when "Just My Code" is off, like we already have in the standard invoke code, although in general that doesn't work either and\or is fragile due to reflection calling non-reflection code such as in Span, Signature, etc. which would also need these attributes.